ExtraTokenBodyParameters, Fixes AB#3435741 #2825
Draft
+104
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
github-actions
bot
changed the title
Copilot finished reviewing on behalf of
melissaahn
December 3, 2025 00:21
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for extraTokenBodyParameters, enabling additional string/string parameter pairs to be included in OAuth2 token request bodies for both interactive and silent token acquisition flows.
- Creates a new interface
IHasExtraTokenBodyParametersto define the contract for classes carrying extra token body parameters - Implements the interface in
InteractiveTokenCommandParametersandBrokerSilentTokenCommandParametersclasses - Updates
MsalBrokerRequestAdapterto serialize these parameters and pass them toBrokerRequest - Extends the IPC schema in
BrokerRequestwith a newEXTRA_TOKEN_BODY_PARAMETERfield
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
IHasExtraTokenBodyParameters.java |
New interface defining the contract for retrieving extra token body parameters; contains a spelling error in documentation |
InteractiveTokenCommandParameters.java |
Implements IHasExtraTokenBodyParameters and adds extraTokenBodyParameters field; missing defensive copy getter |
BrokerSilentTokenCommandParameters.java |
Implements IHasExtraTokenBodyParameters and adds extraTokenBodyParameters field; missing defensive copy getter |
MsalBrokerRequestAdapter.java |
Updates both interactive and silent request methods to serialize and include extra token body parameters; contains code duplication and lacks test coverage |
BrokerRequest.java |
Adds new serialized field mExtraTokenBodyParameter to support IPC transmission of these parameters |
...ain/com/microsoft/identity/common/java/commands/parameters/IHasExtraTokenBodyParameters.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapter.java
Outdated
Show resolved
Hide resolved
...om/microsoft/identity/common/java/commands/parameters/InteractiveTokenCommandParameters.java
Show resolved
Hide resolved
...m/microsoft/identity/common/java/commands/parameters/BrokerSilentTokenCommandParameters.java
Show resolved
Hide resolved
...n/src/main/java/com/microsoft/identity/common/internal/request/MsalBrokerRequestAdapter.java
Show resolved
Hide resolved
...m/microsoft/identity/common/java/commands/parameters/BrokerSilentTokenCommandParameters.java
Show resolved
Hide resolved
...om/microsoft/identity/common/java/commands/parameters/InteractiveTokenCommandParameters.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AB#3435741
The getToken request of the webapps API requires that pairs coming in the extraParameters field will need to be sent for interactive and silent requests. We'll need to send these parameters:
This PR addresses the second point by creating the extraTokenBodyParameter field, which will be parameters added to the body of the token requests.